mistercrunch commented on a change in pull request #4646: Allowing limit
ordering by post-aggregation metrics
URL:
https://github.com/apache/incubator-superset/pull/4646#discussion_r175647696
##########
File path: superset/connectors/druid/models.py
##########
@@ -925,7 +925,18 @@ def metrics_and_post_aggs(metrics, metrics_dict):
visited_postaggs.add(postagg_name)
DruidDatasource.resolve_postagg(
postagg, post_aggs, agg_names, visited_postaggs, metrics_dict)
- return list(agg_names), post_aggs
+ aggs = DruidDatasource.get_aggregations(agg_names, metrics_dict)
Review comment:
by changing the method definition to:
```
@classmethod
def aggs_and_post_aggs(cls, metrics, metrics_dict):
```
you can then `cls.get_aggregations`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
