john-bodley commented on a change in pull request #4655: [druid] Updating
refresh logic
URL:
https://github.com/apache/incubator-superset/pull/4655#discussion_r176225909
##########
File path: tests/druid_tests.py
##########
@@ -29,22 +29,20 @@ def __reduce__(self):
'columns': {
'__time': {
'type': 'LONG', 'hasMultipleValues': False,
- 'size': 407240380, 'cardinality': None, 'errorMessage': None},
+ 'size': 407240380, 'cardinality': None, 'errorMessage': None,
+ },
'dim1': {
'type': 'STRING', 'hasMultipleValues': False,
- 'size': 100000, 'cardinality': 1944, 'errorMessage': None},
+ 'size': 100000, 'cardinality': 1944, 'errorMessage': None,
+ },
'dim2': {
'type': 'STRING', 'hasMultipleValues': True,
- 'size': 100000, 'cardinality': 1504, 'errorMessage': None},
+ 'size': 100000, 'cardinality': 1504, 'errorMessage': None,
+ },
'metric1': {
'type': 'FLOAT', 'hasMultipleValues': False,
- 'size': 100000, 'cardinality': None, 'errorMessage': None},
- },
- 'aggregators': {
Review comment:
@fabianmenges I'm not the original author of this code so I don't have
complete context, but from what I observed whilst debugging was these
aggregators were not being tested. I've re-added this in case I was wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
