john-bodley commented on a change in pull request #4655: [druid] Updating
refresh logic
URL:
https://github.com/apache/incubator-superset/pull/4655#discussion_r176229788
##########
File path: superset/connectors/druid/models.py
##########
@@ -361,21 +361,18 @@ def get_metrics(self):
)
return metrics
- def generate_metrics(self):
- """Generate metrics based on the column metadata"""
- metrics = self.get_metrics()
- dbmetrics = (
- db.session.query(DruidMetric)
Review comment:
@Mogball that was one of my concerns and I agree with your comment. I've
refactored the logic to do one query per `DruidColumn`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
