betodealmeida commented on a change in pull request #4645: CRUD hints around
SQL expressions
URL:
https://github.com/apache/incubator-superset/pull/4645#discussion_r176226170
##########
File path: superset/connectors/sqla/views.py
##########
@@ -57,8 +57,8 @@ class TableColumnInlineView(CompactCRUDMixin,
SupersetModelView): # noqa
'expression-defined columns in some cases. In most case '
'users should not need to alter this.'),
'expression': utils.markdown(
- 'a valid SQL expression as supported by the underlying backend. '
- 'Example: `substr(name, 1, 1)`', True),
+ 'a valid, non-aggregating SQL expression as supported by the '
Review comment:
Nit: use stars around "non-aggregating", for consistency with the other
chance below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
