mistercrunch commented on a change in pull request #4663: [Request For Comments][Explore] Streamlined metric definitions for SQLA and Druid URL: https://github.com/apache/incubator-superset/pull/4663#discussion_r176307661
########## File path: superset/assets/javascripts/explore/components/AggregateOption.jsx ########## @@ -0,0 +1,20 @@ +import React from 'react'; Review comment: I think it's ok to declare more than one component in a module if the component is only used once in that one module. Point being to avoid juggling with lots of small files when possible, the components can be refactored out to its own module when it grows to be used in more than one component. I've been guilty of the other extreme (very long modules) so I'm ok with this if you prefer. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
