codecov-io commented on issue #4663: [Request For Comments][Explore] Streamlined metric definitions for SQLA and Druid URL: https://github.com/apache/incubator-superset/pull/4663#issuecomment-375497877 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4663?src=pr&el=h1) Report > Merging [#4663](https://codecov.io/gh/apache/incubator-superset/pull/4663?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b9965230df9940ca4387f9ac75fab90ed1a9c40a?src=pr&el=desc) will **increase** coverage by `0.13%`. > The diff coverage is `77.97%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4663?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4663 +/- ## ========================================== + Coverage 71.37% 71.51% +0.13% ========================================== Files 190 203 +13 Lines 14918 15244 +326 Branches 1102 1160 +58 ========================================== + Hits 10648 10902 +254 - Misses 4267 4339 +72 Partials 3 3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4663?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz) | `70.58% <ø> (ø)` | :arrow_up: | | [.../javascripts/explore/propTypes/legacyMetricType.js](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvcHJvcFR5cGVzL2xlZ2FjeU1ldHJpY1R5cGUuanM=) | `0% <0%> (ø)` | | | [...et/assets/javascripts/components/OnPasteSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvT25QYXN0ZVNlbGVjdC5qc3g=) | `93.18% <0%> (ø)` | :arrow_up: | | [...assets/javascripts/explore/propTypes/columnType.js](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvcHJvcFR5cGVzL2NvbHVtblR5cGUuanM=) | `100% <100%> (ø)` | | | [...s/javascripts/explore/propTypes/adhocMetricType.js](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvcHJvcFR5cGVzL2FkaG9jTWV0cmljVHlwZS5qcw==) | `100% <100%> (ø)` | | | [...s/javascripts/explore/components/controls/index.js](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100% <100%> (ø)` | :arrow_up: | | [...javascripts/explore/components/AggregateOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9BZ2dyZWdhdGVPcHRpb24uanN4) | `100% <100%> (ø)` | | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `38.8% <100%> (+1.02%)` | :arrow_up: | | [...s/javascripts/explore/propTypes/savedMetricType.js](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvcHJvcFR5cGVzL3NhdmVkTWV0cmljVHlwZS5qcw==) | `100% <100%> (ø)` | | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `88.06% <100%> (+0.1%)` | :arrow_up: | | ... and [26 more](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4663?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4663?src=pr&el=footer). Last update [b996523...934312c](https://codecov.io/gh/apache/incubator-superset/pull/4663?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
