codecov-io commented on issue #4663: [Request For Comments][Explore] Streamlined metric definitions for SQLA and Druid URL: https://github.com/apache/incubator-superset/pull/4663#issuecomment-375497877 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4663?src=pr&el=h1) Report > Merging [#4663](https://codecov.io/gh/apache/incubator-superset/pull/4663?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f9d85bd2e1fd9bc233d19c76bed09467522b968a?src=pr&el=desc) will **increase** coverage by `0.25%`. > The diff coverage is `81.26%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4663?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4663 +/- ## ========================================== + Coverage 71.52% 71.78% +0.25% ========================================== Files 190 201 +11 Lines 14927 15260 +333 Branches 1102 1171 +69 ========================================== + Hits 10677 10954 +277 - Misses 4247 4303 +56 Partials 3 3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4663?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz) | `70.58% <ø> (ø)` | :arrow_up: | | [...et/assets/javascripts/components/OnPasteSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvT25QYXN0ZVNlbGVjdC5qc3g=) | `93.18% <0%> (ø)` | :arrow_up: | | [...javascripts/explore/components/AggregateOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9BZ2dyZWdhdGVPcHRpb24uanN4) | `100% <100%> (ø)` | | | [superset/assets/javascripts/explore/AdhocMetric.js](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvQWRob2NNZXRyaWMuanM=) | `100% <100%> (ø)` | | | [superset/assets/javascripts/explore/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29uc3RhbnRzLmpz) | `100% <100%> (ø)` | | | [...assets/javascripts/explore/propTypes/columnType.js](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvcHJvcFR5cGVzL2NvbHVtblR5cGUuanM=) | `100% <100%> (ø)` | | | [...s/javascripts/explore/propTypes/adhocMetricType.js](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvcHJvcFR5cGVzL2FkaG9jTWV0cmljVHlwZS5qcw==) | `100% <100%> (ø)` | | | [...s/javascripts/explore/components/controls/index.js](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100% <100%> (ø)` | :arrow_up: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `88.06% <100%> (+0.1%)` | :arrow_up: | | [superset/assets/javascripts/dashboard/reducers.js](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9yZWR1Y2Vycy5qcw==) | `50% <100%> (+0.43%)` | :arrow_up: | | ... and [23 more](https://codecov.io/gh/apache/incubator-superset/pull/4663/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4663?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4663?src=pr&el=footer). Last update [f9d85bd...0dc1954](https://codecov.io/gh/apache/incubator-superset/pull/4663?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
