mistercrunch commented on issue #4649: Use one library for table components
URL: 
https://github.com/apache/incubator-superset/issues/4649#issuecomment-376726613
 
 
   We have a cell-measuring utils function somewhere on our side too. 
   
   I think it gets tricky. Picture a report with a wide HDFS folder locations 
as in `/hive/warehouse/default/fact_rides/20180101/file234872948298` and one 
metric (say `megabytes`). You clearly don't want a wrapped `HDFS folder` to 
accommodate a 50% width metric.
   
   Though I like the idea of having consistently sized metrics where one metric 
doesn't look arbitrarily more important than another one just because the label 
is wider. It could be interesting to see how browsers do it (proportion based 
on max(width)? proportion based on avg(wdith)?). I'm guessing it's a bit fuzzy 
and might generally look better than a simpler `width/num_columns`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to