mistercrunch commented on issue #4649: Use one library for table components URL: https://github.com/apache/incubator-superset/issues/4649#issuecomment-374467332 FilterableTable is a wrapper around `react-virtualized` which plays nice tricks to only render what's in the viewport, allowing to render (fake-render really) large datasets which was a requirement for SQL Lab. It's one of those who fake a table (it's not an html `<table>`) so it doesn't know how to scale the width of columns like the normal html `<table>` do. We have to provide hard coded widths somehow for this to work. There's code somewhere that figure out pixels width given a html snippet which is a bit borderline hacky but there are no ways around that I can think of. Personally I like the `reactable` api, allowing to just `<Table data={data} />` but also going down to `Tr` `Td` where/when needed. It's also proper html `<table>` which have good properties and style properly when passing the proper bootstrap classes (`table table-bordered table-condensed ...`). I think we may need both of these ^^^ Now you missed `react-bootstrap-table` which can be replaced by `reactable`. This should be pretty easy to do. Here: `javascripts/dashboard/components/SliceAdder.jsx` Clearly datatables is the non-react weird old jQuery one here that we should kill. It's also pretty big in our bundles, I did some work around removing the dependency, but there's still the `table` and `pivot_table` visualizations that we need to fix up.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
