codecov-io commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#issuecomment-377995539 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=h1) Report > Merging [#4736](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/221b35f36d1682c78c2c85d47827308b99d2cf43?src=pr&el=desc) will **increase** coverage by `0.05%`. > The diff coverage is `84.04%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4736 +/- ## ========================================== + Coverage 72.22% 72.28% +0.05% ========================================== Files 204 204 Lines 15323 15392 +69 Branches 1180 1203 +23 ========================================== + Hits 11067 11126 +59 - Misses 4253 4263 +10 Partials 3 3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...ripts/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `94.11% <ø> (+5.22%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `76.18% <0%> (-1.12%)` | :arrow_down: | | [...pts/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `78.47% <100%> (ø)` | :arrow_up: | | [...s/javascripts/explore/propTypes/adhocMetricType.js](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvcHJvcFR5cGVzL2FkaG9jTWV0cmljVHlwZS5qcw==) | `100% <100%> (ø)` | :arrow_up: | | [...javascripts/SqlLab/components/AceEditorWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIuanN4) | `76.05% <100%> (ø)` | :arrow_up: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `88.07% <100%> (+0.02%)` | :arrow_up: | | [superset/assets/javascripts/explore/AdhocMetric.js](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvQWRob2NNZXRyaWMuanM=) | `94.82% <93.02%> (-5.18%)` | :arrow_down: | | [...ipts/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `86.66% <96.96%> (+3.33%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=footer). Last update [221b35f...c0bf117](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
