codecov-io commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#issuecomment-377995539 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=h1) Report > Merging [#4736](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f6fe11f76e0c890184ac37b25e1a4baf30bc94d1?src=pr&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `80%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4736 +/- ## ========================================== + Coverage 72.38% 72.42% +0.04% ========================================== Files 205 205 Lines 15374 15463 +89 Branches 1182 1205 +23 ========================================== + Hits 11128 11199 +71 - Misses 4243 4261 +18 Partials 3 3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...ripts/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `94.11% <ø> (+5.22%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `76.18% <0%> (-1.12%)` | :arrow_down: | | [...s/javascripts/explore/propTypes/adhocMetricType.js](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvcHJvcFR5cGVzL2FkaG9jTWV0cmljVHlwZS5qcw==) | `100% <100%> (ø)` | :arrow_up: | | [...pts/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `78.62% <100%> (-0.3%)` | :arrow_down: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `88.07% <100%> (+0.02%)` | :arrow_up: | | [superset/assets/javascripts/explore/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29uc3RhbnRzLmpz) | `100% <100%> (ø)` | :arrow_up: | | [...javascripts/SqlLab/components/AceEditorWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIuanN4) | `76.05% <100%> (ø)` | :arrow_up: | | [...ipts/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `80.85% <82.35%> (-2.49%)` | :arrow_down: | | [superset/assets/javascripts/explore/AdhocMetric.js](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvQWRob2NNZXRyaWMuanM=) | `94.91% <93.18%> (-5.09%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=footer). Last update [f6fe11f...fe895c5](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
