john-bodley commented on issue #4520: Allow users to view dashboards they own
URL: 
https://github.com/apache/incubator-superset/pull/4520#issuecomment-380519069
 
 
   @jeffreythewang isn't the current logic that a user is able to see the 
dashboard if the have access to _at least_ one of the underlying slices (as 
opposed to _all_), per this logic:
   ```
   query = query.filter(
       Dash.id.in_(
           db.session.query(Dash.id)
           .distinct()
           .join(Dash.slices)
           .filter(Slice.id.in_(slice_ids_qry)),
        ),
   )
   ```
   My understanding is this query returns the distinct dashboard IDs which are 
represented by _any_ (per the `IN condition) of the sanctioned slices. I wonder 
whether this is being confused with 
https://github.com/apache/incubator-superset/issues/4737.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to