williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180888117
########## File path: superset/assets/javascripts/dashboard/v2/components/gridComponents/Row.jsx ########## @@ -92,6 +93,7 @@ class Row extends React.PureComponent { onResizeStop, handleComponentDrop, editMode, + cells, Review comment: @graceguo-supercat what are cells? (more descriptive name please) it looks like they are only needed by row + column? please us `containers/DashboardComponent` to pass only for those components instead of passing them around everywhere. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services