williaster commented on a change in pull request #4791: apply new Dashboard
builder to dashboard
URL:
https://github.com/apache/incubator-superset/pull/4791#discussion_r180873997
##########
File path:
superset/assets/javascripts/dashboard/components/DashboardContainer.jsx
##########
@@ -1,28 +1,37 @@
import { bindActionCreators } from 'redux';
Review comment:
this should be in `v2/containers` because it's a container. we should fully
separate v1 and v2 so we can easily delete v1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
