williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180874909
########## File path: superset/assets/javascripts/dashboard/components/GridCell.jsx ########## @@ -68,7 +64,7 @@ class GridCell extends React.PureComponent { } width() { - return this.props.widgetWidth - 10; + return this.props.widgetWidth - 32; Review comment: what are these magic numbers? please make them constants / variables if they are necessary. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services