williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180875745
########## File path: superset/assets/javascripts/dashboard/components/SaveModal.jsx ########## @@ -12,18 +12,16 @@ const $ = window.$ = require('jquery'); const propTypes = { css: PropTypes.string, dashboard: PropTypes.object.isRequired, + layout: PropTypes.object.isRequired, Review comment: what's the difference between dashboard and layout? my branch named this `dashboardLayout` which is the most descriptive. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services