Hi all, +1 (binding IPMC Vote, which carries over to the general list).
I checked: - Checked out release - Verified hashes - Verified incubating in names - No binaries in release - Checked NOTICE and LICENSE.txt, README - Started superset from sources using ` docker-compose run --rm superset ./docker-init.sh` -> Works Some (minor) issues found: - No KEYS file found in 'dev' repository only in RELEASE - The Key used to sign is not very "thrustworhy" (short chain of thrust) - LICENSE.txt contains infomrations which I think should belong to NOTICE (but I'm not 100% sure) - README is not very human readable. Perhaps one should split it in one for humas and one which is sued to generate the Homepage? - Start / Installation instructions should be directly in the README (IMHO) - Following warning while building docker Container: ``` debconf: unable to initialize frontend: Dialog debconf: (TERM is not set, so the dialog frontend is not usable.) debconf: falling back to frontend: Readline debconf: unable to initialize frontend: Readline debconf: (This frontend requires a controlling tty.) debconf: falling back to frontend: Teletype dpkg-preconfigure: unable to re-open stdin: ``` - The docker start script asks me for input (admin name, ...). This is not listed in the installation instructions - Another Hint: Generally its good to start a [DISCUSS] Thread parallel to the [VOTE] Thread. Then it becomes easier to follow the VOTE thread as it stays "cleaner". Good Job! Best Julian Am 19.08.19, 12:42 schrieb "Julian Feinauer" <[email protected]>: Hi, and another (minor) comment. Although committer releases are not binding they should nonetheless take the time to vote. First, because they could become PPMC members and second because although the VOTE is not binding, it may nonetheless be recognized and could have influence. Julian Am 19.08.19, 11:53 schrieb "Justin Mclean" <[email protected]>: HI, > We need binding votes from the committers... 3 being the minimum. Its common to make it clear that you are either voting binding or non binding. Binding votes can only be cast by committers. Actually only the PMC votes are binding, committer votes are not binding on releases. In the incubator it's expected you get 3 PPMC votes on the dev list and then 3 IPMC on teh incubator general list. You need more +1 votes than -1 votes as well. Thanks, Justin
