Hi Alan, two things I noticed. First, if the VOTE is already closed there should be a separate thread "[RESULT][VOTE] xxx" where you summarize the results. Second, if the vote is not yet closed I can offer to also check the release and cast a +1 binding IPMC Vote. It is best to have as much IPMC votes here on your list already (like Justins) to loosen pressure on the IPMC.
We are currently considering using Superset, so I'll happily offer my help here. Julian On 2019/08/17 17:18:48, Alan Gates <[email protected]> wrote: > Yes, mentors are required to be part of the IPMC. When Max starts the > thread on general I'll forward my +1. So we'll just need one more, since > we also have Jakob's. > > Alan. > > > On Sat, Aug 17, 2019 at 2:50 AM Bolke de Bruin <[email protected]> wrote: > > > Alan > > > > Are you ipmc member as well? If so does your vote carry forward to the > > ipmc together with Jakob’s? Maybe its good to include that? > > > > B. > > > > Verstuurd vanaf mijn iPad > > > > > Op 16 aug. 2019 om 22:10 heeft Alan Gates <[email protected]> het > > volgende geschreven: > > > > > > Yes. > > > > > > Alan. > > > > > > On Fri, Aug 16, 2019 at 12:45 PM Maxime Beauchemin < > > > [email protected]> wrote: > > > > > >> @mentors, so should I kick off a vote with general@ now? > > >> > > >> Max > > >> > > >>> On Fri, Aug 16, 2019 at 12:00 PM Jakob Homan <[email protected]> > > wrote: > > >>> > > >>> +1 (binding) > > >>> * Some LICENSEs appear to be missing; can be fixed next release > > >>> * Artifact contains rc1 suffix; usually this isn't the case. Not sure > > >>> if the IPMC will be concerned > > >>> * Sig looks good > > >>> * DISCLAIMER/LICENSE (other than above)/NOTICE look good > > >>> * Spot check on headers look good > > >>> > > >>> -Jakob > > >>> > > >>> On Thu, Aug 15, 2019 at 4:11 PM Beto Dealmeida <[email protected]> > > >>> wrote: > > >>>> > > >>>> I can take a look at the release today and vote. > > >>>> > > >>>>> On 8/15/19 3:51 PM, Alan Gates wrote: > > >>>>> We should have a 3rd PPMC vote. If we can get Thejas or Jakob to > > >> vote > > >>> as > > >>>>> mentors that will give us another PPMC vote and one more IPMC vote. > > >>>>> > > >>>>> Alan. > > >>>>> > > >>>>> On Thu, Aug 15, 2019 at 2:26 PM Maxime Beauchemin < > > >>>>> [email protected]> wrote: > > >>>>> > > >>>>>> Vote passes! > > >>>>>> > > >>>>>> +2 binding votes (Alan & Max) > > >>>>>> +3 non-binding vote (Ville, Charles, Bolke) > > >>>>>> > > >>>>>> No neutral or negative votes. > > >>>>>> > > >>>>>> Now (assuming 2 binding votes are enough) I have to figure out what > > >> my > > >>>>>> steps are. I think it consist of starting a vote thread similar to > > >>> this one > > >>>>>> on [email protected] where I [think I] need 3 or more > > >> IPMC > > >>>>>> binding votes. > > >>>>>> > > >>>>>> Max > > >>>>>> > > >>>>>> On Mon, Aug 12, 2019 at 2:48 PM Maxime Beauchemin < > > >>>>>> [email protected]> wrote: > > >>>>>> > > >>>>>>> +cc Justin I'd appreciate if you could do a pass on this as you > > >>>>>> uncovered > > >>>>>>> the most issues last time > > >>>>>>> > > >>>>>>> Thanks, > > >>>>>>> > > >>>>>>> Max > > >>>>>>> > > >>>>>>> On Mon, Aug 12, 2019 at 1:38 PM Maxime Beauchemin < > > >>>>>>> [email protected]> wrote: > > >>>>>>> > > >>>>>>>> We should probably develop and evolve guidelines on what > > >>> constitutes a > > >>>>>>>> release blocker. For this first Apache release I think we're more > > >>>>>> focussed > > >>>>>>>> on license-related topics and ASF-type requirements along with > > >>> "P0"-type > > >>>>>>>> blockers that would make significant portions of Superset > > >> unusable. > > >>>>>>>> > > >>>>>>>> Bellow are some of the issues raised in a previous release attempt > > >>> (from > > >>>>>>>> an email that Justin McLean sent). I believe everything in there > > >> has > > >>>>>> been > > >>>>>>>> tackled, but we should probably double check. > > >>>>>>>> > > >>>>>>>> ``` > > >>>>>>>> I checked: > > >>>>>>>> - incubating is missing from name > > >>>>>>>> - signatures and hashes good > > >>>>>>>> - DISCLAIMER exists > > >>>>>>>> - LICENSE is missing a few licenses (see below) > > >>>>>>>> - NOTICE should not include LICENSE information e.g The line about > > >>> CC > > >>>>>>>> 4.0. This may need to be removed. Also this content may be > > >> Category > > >>> X > > >>>>>> and > > >>>>>>>> this can’t included in a source release. [11] > > >>>>>>>> - Some 3rd party code have headers with "[LICENSE TBD]” > > >>> [4][5][6][7][9] > > >>>>>>>> which seems odd > > >>>>>>>> - The ASF headers on a number of files are not correct e.g the > > >> file > > >>> [13] > > >>>>>>>> and other under that directory (search for COPYRIGHT 2016 and and > > >>>>>> COPYRIGHT > > >>>>>>>> 2017 and COPYRIGHT 2018) Or are these files not actually licensed > > >>> to the > > >>>>>>>> ASF? > > >>>>>>>> - Source release may contained compiled code e.g [20] my > > >>> understanding > > >>>>>> is > > >>>>>>>> that a .mo file is compiled from the .po file. I not sure if it > > >>> could be > > >>>>>>>> classified as code however, but even if that is so it may be best > > >> to > > >>>>>> remove > > >>>>>>>> them from the source release. > > >>>>>>>> > > >>>>>>>> There is a few bits of missing licensing information: > > >>>>>>>> - How is the map date here licensed? [3] Is it from > > >>>>>>>> http://www.diva-gis.org/Data? I can see there is a credit in the > > >>> code > > >>>>>>>> that has a link to https://bl.ocks.org/john-guerra. How is that > > >>> code > > >>>>>>>> licensed? > > >>>>>>>> - This file [7] is missing from LICENSE I assume it’s public > > >>> domain? [8] > > >>>>>>>> - This file [9] is licensed how? It seems to come from here [10] > > >>> which > > >>>>>>>> says to contact the author for a license. > > >>>>>>>> - How is this image [14] licensed? (One reference I found said it > > >>> could > > >>>>>>>> only be used for personal use [21]) > > >>>>>>>> - LICENSE is missing license information for these fonts > > >>>>>>>> [15][16][17][18][19] The license for Glyphicons Halflings is > > >> complex > > >>>>>> and in > > >>>>>>>> this context (outside of bootstrap) a commercial license may be > > >>> needed > > >>>>>> [22] > > >>>>>>>> and so it can’t be included. > > >>>>>>>> > > >>>>>>>> Some other improvements that could be made: > > >>>>>>>> - The LICENSE fieldworker is a little odd with headings like BSD > > >>>>>> 2-Clause > > >>>>>>>> licenses with noting under them, people (or tools) may incorrectly > > >>>>>> assume > > >>>>>>>> that it does contain BSD 2-Clause licensed code. > > >>>>>>>> - Make vote link link in future emails to lists.apache,org > > >>>>>>>> - Sign release with an apache.org email address > > >>>>>>>> - This [12] has copyright 2018 when it shovel be 2019 > > >>>>>>>> > > >>>>>>>> Thanks, > > >>>>>>>> Justin > > >>>>>>>> > > >>>>>>>> 1. https://incubator.apache.org/policy/incubation.html#releases > > >>>>>>>> 2. > > >>>>>>>> > > >>>>>> > > >>> > > >> > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > >>>>>>>> 3. apache-superset > > >>>>>>>> -0.32.0rc2/superset/assets/src/visualizations/CountryMap/* > > >>>>>>>> 4. > > >>>>>> > > >>> > > >> > > apache-superset-0.32.0rc2/superset/assets/vendor/cal-heatmap/cal-heatmap.js > > >>>>>>>> / .css > > >>>>>>>> 5 > > >>>>>> > > >>> > > >> > > apache-superset-0.32.0rc2/superset/assets/vendor/parallel_coordinates/d3.parcoords.js > > >>>>>>>> / .css > > >>>>>>>> 6. apache-superset > > >>>>>>>> -0.32.0rc2/superset/assets/vendor/parallel_coordinates/divgrid.js > > >>>>>>>> 7 apache-superset-0.32.0rc2/superset/assets/vendor/pygments.css > > >>>>>>>> 8. > > >>> https://github.com/richleland/pygments-css/blob/master/UNLICENSE.txt > > >>>>>>>> 9. ./apache-superset > > >>>>>>>> -0.32.0rc2/superset/assets/vendor/parallel_coordinates/divgrid.js > > >>>>>>>> 10. http://bl.ocks.org/syntagmatic/3687826 > > >>>>>>>> 11. > > >>> http://www.tavfrna.incubator.apache.org/legal/resolved.html#cc-sa > > >>>>>>>> 12. ./apache-superset-0.32.0rc2/docs/conf.py > > >>>>>>>> 13. ./apache-superset-0.32.0rc2/superset/translations/messages.pot > > >>>>>>>> 14. ./apache-superset-0.32.0rc2/superset/assets/images/babytux.jpg > > >>>>>>>> 15. apache-superset > > >>>>>>>> -0.32.0rc2/superset/assets/stylesheets/fonts/Roboto-Regular.woff > > >>>>>>>> 16. apache-superset > > >>>>>>>> -0.32.0rc2/superset/assets/stylesheets/fonts/Roboto-Regular.woff2 > > >>>>>>>> 17. apache-superset > > >>>>>>>> > > >>>>>> > > >>> > > >> > > -0.32.0rc2/superset/assets/stylesheets/fonts/glyphicons-halflings-regular.ttf > > >>>>>>>> 18. apache-superset > > >>>>>>>> > > >>>>>> > > >>> > > >> > > -0.32.0rc2/superset/assets/stylesheets/fonts/glyphicons-halflings-regular.woff > > >>>>>>>> 19. apache-superset > > >>>>>>>> > > >>>>>> > > >>> > > >> > > -0.32.0rc2/superset/assets/stylesheets/fonts/glyphicons-halflings-regular.woff2 > > >>>>>>>> 20 apache-superset > > >>>>>>>> -0.32.0rc2/superset/translations/de/LC_MESSAGES/messages.mo > > >>>>>>>> 21. https://www.pngfly.com/png-79pbyi/ > > >>>>>>>> 22. https://www.glyphicons.com/license/ > > >>>>>>>> ```` > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> Max > > >>>>>>>> > > >>>>>>>> On Mon, Aug 12, 2019 at 10:55 AM Charles Givre <[email protected]> > > >>>>>> wrote: > > >>>>>>>>> > > >>>>>>>>> > > >>>>>>>>> I built and ran some queries in SQL Lab, created some > > >>> visualizations. > > >>>>>>>>> > > >>>>>>>>> I did encounter an issue, which is not new, but I'd love to see > > >>> fixed. > > >>>>>>>>> Specifically, when I attempt to create a line chart, I run the > > >>> query, > > >>>>>> but > > >>>>>>>>> in order to actually get the visualization, I have to refresh my > > >>>>>> browser. > > >>>>>>>>> However, this is not new so I'll open a ticket. > > >>>>>>>>> > > >>>>>>>>> > > >>>>>>>>> +1 (non-binding) from me. > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>>> On Aug 12, 2019, at 1:22 PM, Ville Brofeldt < > > >>>>>>>>> [email protected] <mailto:[email protected]>> > > >>> wrote: > > >>>>>>>>>>> It's my understanding that only PMC members can cast binding > > >>> votes. > > >>>>>>>>> Hence > > >>>>>>>>>>> my non-binding vote (committer, not PMC member). Ville > > >>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>>> On Mon, Aug 12, 2019, 20:08 Bolke de Bruin <[email protected] > > >>>>>>>>> <mailto:[email protected]>> wrote: > > >>>>>>>>>>>> We need binding votes from the committers... 3 being the > > >>> minimum. > > >>>>>> Its > > >>>>>>>>>>>> common to make it clear that you are either voting binding or > > >>> non > > >>>>>>>>> binding. > > >>>>>>>>>>>> Binding votes can only be cast by committers. > > >>>>>>>>>>>> > > >>>>>>>>>>>> This is my +1, NON-binding. > > >>>>>>>>>>>> > > >>>>>>>>>>>> Bolke > > >>>>>>>>>>>> > > >>>>>>>>>>>> Verstuurd vanaf mijn iPad > > >>>>>>>>>>>> > > >>>>>>>>>>>>> Op 10 aug. 2019 om 06:16 heeft Ville Brofeldt < > > >>>>>>>>>>>> [email protected] <mailto:[email protected] > > >>>> > > >>>>>> het > > >>>>>>>>> volgende geschreven: > > >>>>>>>>>>>>> Hi all, > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> I believe this is a good point in time to cut the 0.34 > > >>> release, as > > >>>>>>>>> there > > >>>>>>>>>>>>> have been numerous important bugfixes and features introduced > > >>>>>> since > > >>>>>>>>> 0.33, > > >>>>>>>>>>>>> with especially important license housekeeping in the form of > > >>>>>>>>> removal of > > >>>>>>>>>>>>> requests (thanks Gianluca!) and FOSSA CI (thanks Max!). So > > >>> would > > >>>>>>>>> like to > > >>>>>>>>>>>>> extend my non-binding +1 to this. Fingers crossed! > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> Ville > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> On Fri, Aug 9, 2019 at 9:36 PM Maxime Beauchemin < > > >>>>>>>>>>>> [email protected] <mailto:[email protected] > > >>>> > > >>>>>>>>>>>>> wrote: > > >>>>>>>>>>>>> > > >>>>>>>>>>>>>> Dear all, > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> The source release 0.34.0 RC1 for Apache Superset is baked > > >> and > > >>>>>>>>> available > > >>>>>>>>>>>>>> at: > > >>>>>>>>>>>>>> https://dist.apache.org/repos/dist/dev/incubator/superset/ > > >> < > > >>>>>>>>> https://dist.apache.org/repos/dist/dev/incubator/superset/>, > > >>> public > > >>>>>>>>>>>>>> keys are available > > >>>>>>>>>>>>>> at > > >>>>>>>>> > > >> https://dist.apache.org/repos/dist/release/incubator/superset/KEYS > > >>> < > > >>>>>>>>> > > >> https://dist.apache.org/repos/dist/release/incubator/superset/KEYS > > >>>> > > >>>>>>>>>>>>>> We're using the 0.34 branch as the base for this first ASF > > >>>>>> release > > >>>>>>>>> as > > >>>>>>>>>>>>>> opposed to 0.33 in previous attempts. I think all > > >>> license-related > > >>>>>>>>> issues > > >>>>>>>>>>>>>> have been ironed out in our dependency, here's the FOSSA > > >>> report > > >>>>>>>>>>>>>> < > > >>>>>>>>>>>>>> > > >>>>>> > > >>> > > >> > > https://app.fossa.com/projects/custom+11342%[email protected]:apache%2Fincubator-superset.git/refs/branch/0.34/a04fad858644466219b7ea399aead110cb8ea655 > > >>>>>>>>> < > > >>>>>>>>> > > >>>>>> > > >>> > > >> > > https://app.fossa.com/projects/custom+11342%[email protected]:apache%2Fincubator-superset.git/refs/branch/0.34/a04fad858644466219b7ea399aead110cb8ea655 > > >>>>>>>>>>>>>> . *We're still ironing out our release process, so please > > >> bear > > >>>>>>>>> with us > > >>>>>>>>>>>> and > > >>>>>>>>>>>>>> help if you can*. > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> As I went along, I documented the process in > > >>> [yet-to-be-merged] > > >>>>>>>>>>>>>> RELEASING/README.md in the repo, latest edits here # > > >>>>>>>>>>>>>> <https://github.com/apache/incubator-superset/pull/8016 > > >>> 8016 > > >>>>>>>>>>>>>> <https://github.com/apache/incubator-superset/pull/8016>. > > >> As > > >>>>>> part > > >>>>>>>>> of > > >>>>>>>>>>>>>> `RELEASING/`, we ship docker files to help test releases in > > >> a > > >>>>>>>>>>>> reproducible > > >>>>>>>>>>>>>> way. > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> For context the `0.34` release branch was cut at SHA > > >> 9233a63, > > >>>>>> that > > >>>>>>>>> was > > >>>>>>>>>>>>>> merged on master on Aug 8th 2019. From that common ancestor, > > >>> the > > >>>>>>>>>>>> following > > >>>>>>>>>>>>>> list of commit was added as cherry-picks. The SHAs in the > > >> list > > >>>>>>>>> bellow > > >>>>>>>>>>>>>> reference the cherries on the release branch, PR number are > > >>>>>>>>> available to > > >>>>>>>>>>>>>> get more details. > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> <no cherries yet on the 0.34 branch> > > >>>>>>>>>>>>>> > > >>>>>>>>>>>> > > >>>>>>>>> > > >>> > > >> > > >
