Hi Max,
Maximilian Odendahl wrote:
Hi,
so that notes and change tracking always have the same color, I would like to
harmonize their use of authors.
- would it be save to change STR_REDLINE_UNKNOWN_AUTHOR from "unknown" to just an empty
string or sth. different such as "unknown author", or is there some hidden danger which I
oversee?
This string is stored into the ODF file. So if you change this string to
"unknown author" it will have a small side effect. If you open an older
document which contains "unknown" as creator and now you have "unknown
author" then new change trackings will get another color than your old
changes.
- if last and firstname is empty, but initials are not, I would like to take
that as author name for change tracking as well
The only small disadvantage is the same as above: your initials will
stored as change tracking creator into the ODF file. If you later on
fill your last/first name you will get another color for your changes.
Comments?
Regards
Max
PS: As a sidenote and more a cosmetic than neccessary change, I would change
sActAuthor to be a local variable instead of a global one in SwModule, as it is
only used inside one function, seems pretty local to me ;-)
Even it is only used in one function, it's value is cached by SwModule.
It is initialized only in the first call of that function (or if the
user data has been changed). If you change it into a local variable you
have to evaluate it every call.
Regards
Andreas
--
Andreas Martens (ama) - OpenOffice.org Writer
OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
