[
https://issues.apache.org/jira/browse/SYNAPSE-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608969#action_12608969
]
Ruwan Linton commented on SYNAPSE-379:
--------------------------------------
Hiranya,
I have gone through the patch and seems completely OK to me. Sort of green
light ;-). At the same time I must say that our strategy on committers is
commit and review so as a committer you do not need to give a patch and review
it before committing unless we are on a release branch and just in front of a
release. If something is wrong someone can raise an issue on the list for that
particular commit and ask to revert it back.
Thanks,
Ruwan
> Documentation doesn't describe FIX transport parameters
> --------------------------------------------------------
>
> Key: SYNAPSE-379
> URL: https://issues.apache.org/jira/browse/SYNAPSE-379
> Project: Synapse
> Issue Type: Bug
> Components: Documentation
> Reporter: Asanka Abeysinghe
> Assignee: Hiranya Jayathilaka
> Fix For: 1.2
>
> Attachments: fix-docs.patch
>
>
> Documentation doesn't describe FIX transport parameters. Usage of the
> parameters and number of parameters available not visible in the user
> documentation + API guide.
> transport.fix.AcceptorConfigURL- used in sample 257 but not described in
> detail
> transport.fix.InitiatorConfigURL- used in sample 257 but not described in
> detail
> transport.fix.AcceptorLogFactory- used in sample 257 but not described in
> detail
> transport.fix.InitiatorLogFactory- used in sample 257 but not described in
> detail
> transport.fix.AcceptorMessageStore- used in sample 257 but not described in
> detail
> transport.fix.InitiatorMessageStore- used in sample 257 but not described in
> detail
> transport.fix.ResponseDeliverToCompID- not described
> transport.fix.ResponseDeliverToSubID- not described
> transport.fix.ResponseDeliverToLocationID- not described
> transport.fix.ServiceName-used in sample 258 but not described in detail
> transport.fix.SendAllToInSequence- not described
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
