Asankha, Can you commit it to a private branch? That makes it easy to see both the differences with respect to the existing code as well as incremental changes.
Andreas On Fri, Nov 14, 2008 at 02:38, Asankha C. Perera <[EMAIL PROTECTED]> wrote: > Hi Andreas >> >> The testkit logs show lots of TransportDisposedIOExceptions in the >> tests based on ActiveMQ. This is not the case for the current version >> of the JMS transport. Could it be that some JMS resources are not >> properly closed? > > Ok.. I will check this.. I have done more cleanup and a re-review of the > code, and will check the logs now.. also I will check the min-concurrency > test again considering your comments.. I did see the latch counting down to > zero with souts, but from within the IDE, I've seen it get stuck.. Let me > check the resource cleanup code as well, to see if synchronization is > required to ensure proper behavior. I also used volatiles to notify shutdown > etc, which should generally improve things for better >> >> Also I've seen some random failures, but I need more >> time to collect relevant information. Could you give me some more time >> to thoroughly test and review the patch? >> > > Sure Andreas.. since I have done a few more changes, I can either commit > this to a private branch so that both of us can work on it together.. or > even trunk if you feel its ready.. or I can also send the latest patch (with > whatever changes I have done since Wednesday) whenever you can find some > time to go through.. Let me know what will work best.. > > asankha > > -- > Asankha C. Perera > http://adroitlogic.org > > http://esbmagic.blogspot.com > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
