On Sat, Apr 4, 2009 at 5:44 PM, Andreas Veithen <[email protected]>wrote:
> On Sat, Apr 4, 2009 at 13:50, Ruwan Linton <[email protected]> wrote: > > > > > > On Sat, Apr 4, 2009 at 4:28 PM, Hiranya Jayathilaka < > [email protected]> > > wrote: > >> > >> I believe slf4j is required only for the FIX transport. It is a MINA > >> dependency which is used by Quickfix/J. If it is not used by anything > else > >> we should remove this. > > > > Good point, Asankha, are we going to ship the QFJ jar files, I think we > have > > decided to remove these and document this under the fix transport > > configuration for the user to put in these dependencies upon configuring > it, > > right?? > > This JAR only takes 9 KB. I would just leave it in the distribution. > The advantage is that whenever a user adds a library that uses the > SLF4J framework, logging will correctly work out of the box without > the need for the user to understand the relationship between log4j, > SLF4J and commons-logging. I am completely OK with keeping this, but not QuickFixJ and other related dependencies, because FIX is a domain specific transport which wont be required for many users. Ruwan > > > > > > Thanks, > > Ruwan > > > >> > >> Thanks, > >> Hiranya > >> > >> On Sat, Apr 4, 2009 at 1:17 PM, Hubert, Eric <[email protected] > > > >> wrote: > >>> > >>> > >>>>> ./slf4j-log4j12-1.5.6.jar > >>> > > >>> > There is at least one dependency (I don't remember which one) that > >>> > uses SLF4J as abstract logging framework. Since we use log4j as > >>> > concrete implementation, we need the SLF4J-log4j bridge. > >>> It looks like there are more than one dependency, but the one Andreas > is > >>> referring to could be qpid, but also mina seems too use sl4j as logging > >>> abstraction. > >>> Although I'm not sure we need to declare them directly in the > transports > >>> as I don't think synapse will have direct code usage of neither API nor > >>> IMPL. > >>> > >>> Regards, > >>> Eric > >> > > > > > > > > -- > > Ruwan Linton > > Senior Software Engineer & Product Manager; WSO2 ESB; > http://wso2.org/esb > > WSO2 Inc.; http://wso2.org > > email: [email protected]; cell: +94 77 341 3097 > > blog: http://ruwansblog.blogspot.com > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Ruwan Linton Senior Software Engineer & Product Manager; WSO2 ESB; http://wso2.org/esb WSO2 Inc.; http://wso2.org email: [email protected]; cell: +94 77 341 3097 blog: http://ruwansblog.blogspot.com
