Modified the synapse patching process which was based on jars that which were added to /patches/jars. Now the patches are created based on the required source files stored in patches/src during compile time. Also removed existing redundant patches from /patches/jars.
On Wed, Dec 14, 2011 at 11:04 AM, Kasun Indrasiri <[email protected]>wrote: > > > On Wed, Dec 14, 2011 at 10:52 AM, Ruwan Linton <[email protected]>wrote: > >> to clarify, I originally meant this approach, and I missed how this has >> actually been implemented. >> >> <quote from thread "Upgrading to Commons VFS 2"> >> So the commons-vfs patch will be a small maven module with just the >> patched classes using the released artifact as a compile time dependency >> and the synapse distribution build will need to copy that tiny patch into >> the patches directory of the synapse lib. >> </quote> >> >> Kasun, will you be able to do the necessary changes? >> >> Yeah, I'm working on the required changes. However, already we have[1] in > synapse patches which also doesn't adhere to the requirements mentioned by > Andreas. (Anyway we are going to get rid of this httpcore patch as the > patch is already available in the 4.1 release) > > [1] > https://svn.apache.org/repos/asf/synapse/trunk/java/modules/patches/jars/httpcore-nio-4.0-patch-httpcore-193.jar > > > Thanks, >> Ruwan >> >> >> On Wed, Dec 14, 2011 at 10:44 AM, Ruwan Linton <[email protected]>wrote: >> >>> +1 >>> >>> Ruwan >>> >>> >>> On Wed, Dec 14, 2011 at 10:18 AM, Hiranya Jayathilaka < >>> [email protected]> wrote: >>> >>>> >>>> >>>> On Wed, Dec 14, 2011 at 12:34 AM, Andreas Veithen < >>>> [email protected]> wrote: >>>> >>>>> -1 >>>>> >>>>> I think that this approach is incompatible with the ASL because we >>>>> would distribute binaries (that are not 3rd party binaries with an >>>>> appropriate license) without distributing the corresponding source >>>>> code. I think that the patch should be produced from sources during >>>>> the Synapse build. >>>>> >>>> >>>> I think you're right. We should put the patched source files under >>>> modules/patches. Not the binary. >>>> >>>> >>>>> >>>>> Andreas >>>>> >>>>> On Tue, Dec 13, 2011 at 11:01, Kasun Indrasiri <[email protected]> >>>>> wrote: >>>>> > Hi devs, >>>>> > >>>>> > I've completed the upgrading of commons vfs to version 2.0. Also add >>>>> the >>>>> > required fixes with synapse patching mechanism. [1] >>>>> > >>>>> > [1] >>>>> https://svn.apache.org/repos/asf/synapse/trunk/java/modules/patches/jars/commons-vfs2-2.0-vfs-178.jar >>>>> > >>>>> > Thanks. >>>>> > -- >>>>> > Kasun Indrasiri >>>>> > Senior Software Engineer, >>>>> > WSO2 Inc. - "Lean . Enterprise . Middleware" - http://www.wso2.com/ >>>>> > Blog : http://kasunpanorama.blogspot.com/ >>>>> > >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: [email protected] >>>>> For additional commands, e-mail: [email protected] >>>>> >>>>> >>>> >>>> >>>> -- >>>> Hiranya Jayathilaka >>>> Associate Technical Lead; >>>> WSO2 Inc.; http://wso2.org >>>> E-mail: [email protected]; Mobile: +94 77 633 3491 >>>> Blog: http://techfeast-hiranya.blogspot.com >>>> >>> >>> >>> >>> -- >>> Ruwan Linton >>> Member, Apache Software Foundation; http://www.apache.org >>> Director of Engineering; http://adroitlogic.org >>> >>> phone: +94 11 282 7532 >>> email: [email protected]; cell: +94 77 341 3097 >>> blog: http://blog.ruwan.org >>> linkedin: http://www.linkedin.com/in/ruwanlinton >>> google: http://www.google.com/profiles/ruwan.linton >>> tweet: http://twitter.com/ruwanlinton >>> >>> >> >> >> -- >> Ruwan Linton >> Member, Apache Software Foundation; http://www.apache.org >> Director of Engineering; http://adroitlogic.org >> >> phone: +94 11 282 7532 >> email: [email protected]; cell: +94 77 341 3097 >> blog: http://blog.ruwan.org >> linkedin: http://www.linkedin.com/in/ruwanlinton >> google: http://www.google.com/profiles/ruwan.linton >> tweet: http://twitter.com/ruwanlinton >> >> > > > -- > Kasun Indrasiri > Associate Technical Lead, > > WSO2 Inc. - "Lean . Enterprise . Middleware" - http://www.wso2.com/ > Blog : http://kasunpanorama.blogspot.com/ > > -- Kasun Indrasiri Associate Technical Lead, WSO2 Inc. - "Lean . Enterprise . Middleware" - http://www.wso2.com/ Blog : http://kasunpanorama.blogspot.com/
