ilgrosso commented on a change in pull request #189: URL: https://github.com/apache/syncope/pull/189#discussion_r429891279
########## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/auth/AuthProfile.java ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.syncope.core.persistence.api.entity.auth; + +import org.apache.syncope.common.lib.types.GoogleMfaAuthToken; +import org.apache.syncope.core.persistence.api.entity.Entity; + +import java.util.List; + +public interface AuthProfile extends Entity { + + String getOwner(); + + void setOwner(String owner); + + List<GoogleMfaAuthToken> getGoogleMfaAuthTokens(); + + void setGoogleMfaAuthTokens(List<GoogleMfaAuthToken> tokens); Review comment: This setter method is generally not required by other entities. ########## File path: core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/data/AuthProfileDataBinder.java ########## @@ -0,0 +1,27 @@ +/* Review comment: This class should not be needed, the purpose of databinding is to transform entities in TOs and viceversa. Just use `entityFactory` in the calling place. ########## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/dao/auth/AuthProfileDAO.java ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.syncope.core.persistence.api.dao.auth; + +import org.apache.syncope.core.persistence.api.dao.DAO; +import org.apache.syncope.core.persistence.api.entity.auth.AuthProfile; + +import java.util.List; +import java.util.Optional; + +public interface AuthProfileDAO extends DAO<AuthProfile> { + + List<AuthProfile> findAll(); Review comment: How to delete an `AuthProfile` instance? ########## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/GoogleMfaAuthTokenDataBinderImpl.java ########## @@ -0,0 +1,50 @@ +/* Review comment: As said above. ########## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/auth/AuthProfile.java ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.syncope.core.persistence.api.entity.auth; + +import org.apache.syncope.common.lib.types.GoogleMfaAuthToken; +import org.apache.syncope.core.persistence.api.entity.Entity; + +import java.util.List; + +public interface AuthProfile extends Entity { + + String getOwner(); + + void setOwner(String owner); + + List<GoogleMfaAuthToken> getGoogleMfaAuthTokens(); + + void setGoogleMfaAuthTokens(List<GoogleMfaAuthToken> tokens); + + void addGoogleMfaAuthToken(GoogleMfaAuthToken token); Review comment: `add()` should be enough (see other entities) ########## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/auth/AuthProfile.java ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.syncope.core.persistence.api.entity.auth; + +import org.apache.syncope.common.lib.types.GoogleMfaAuthToken; +import org.apache.syncope.core.persistence.api.entity.Entity; + +import java.util.List; + +public interface AuthProfile extends Entity { + + String getOwner(); + + void setOwner(String owner); + + List<GoogleMfaAuthToken> getGoogleMfaAuthTokens(); + + void setGoogleMfaAuthTokens(List<GoogleMfaAuthToken> tokens); + + void addGoogleMfaAuthToken(GoogleMfaAuthToken token); + + void clearGoogleMfaAuthTokens(); Review comment: This method is generally not required by other entities. ########## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AuthProfileDataBinderImpl.java ########## @@ -0,0 +1,39 @@ +/* Review comment: As said above. ########## File path: common/am/lib/src/main/java/org/apache/syncope/common/lib/to/GoogleMfaAuthTokenTO.java ########## @@ -0,0 +1,143 @@ +/* Review comment: This class is not needed, just use `GoogleMfaAuthToken` everywhere. ########## File path: core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/data/GoogleMfaAuthTokenDataBinder.java ########## @@ -0,0 +1,30 @@ +/* Review comment: This class should not be needed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
