ilgrosso commented on a change in pull request #189: URL: https://github.com/apache/syncope/pull/189#discussion_r430202043
########## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/auth/AuthProfile.java ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.syncope.core.persistence.api.entity.auth; + +import org.apache.syncope.common.lib.types.GoogleMfaAuthToken; +import org.apache.syncope.core.persistence.api.entity.Entity; + +import java.util.List; + +public interface AuthProfile extends Entity { + + String getOwner(); + + void setOwner(String owner); + + List<GoogleMfaAuthToken> getGoogleMfaAuthTokens(); + + void setGoogleMfaAuthTokens(List<GoogleMfaAuthToken> tokens); Review comment: exactly, it is not needed, following the general approach we use everywhere else ########## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/dao/auth/AuthProfileDAO.java ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.syncope.core.persistence.api.dao.auth; + +import org.apache.syncope.core.persistence.api.dao.DAO; +import org.apache.syncope.core.persistence.api.entity.auth.AuthProfile; + +import java.util.List; +import java.util.Optional; + +public interface AuthProfileDAO extends DAO<AuthProfile> { + + List<AuthProfile> findAll(); Review comment: for administration purpose, I mean; I think we should also have an `AuthProfileService` allowing to browse and delete the available profiles. ########## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/auth/AuthProfile.java ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.syncope.core.persistence.api.entity.auth; + +import org.apache.syncope.common.lib.types.GoogleMfaAuthToken; +import org.apache.syncope.core.persistence.api.entity.Entity; + +import java.util.List; + +public interface AuthProfile extends Entity { + + String getOwner(); + + void setOwner(String owner); + + List<GoogleMfaAuthToken> getGoogleMfaAuthTokens(); + + void setGoogleMfaAuthTokens(List<GoogleMfaAuthToken> tokens); Review comment: I was referring to the fact of having setter for collection, which we don't generally do; however, it seems that [JPAConnInstance](https://github.com/apache/syncope/blob/master/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPAConnInstance.java#L195) is exactly in the same situation, as the collection is being serialized to JSON. Sorry for the noise! ########## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/dao/auth/AuthProfileDAO.java ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.syncope.core.persistence.api.dao.auth; + +import org.apache.syncope.core.persistence.api.dao.DAO; +import org.apache.syncope.core.persistence.api.entity.auth.AuthProfile; + +import java.util.List; +import java.util.Optional; + +public interface AuthProfileDAO extends DAO<AuthProfile> { + + List<AuthProfile> findAll(); Review comment: Correct ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
