ilgrosso commented on a change in pull request #221:
URL: https://github.com/apache/syncope/pull/221#discussion_r508254228



##########
File path: 
core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/auth/SAML2SP.java
##########
@@ -73,4 +75,28 @@
     void setServiceProviderNameIdQualifier(String location);
 
     String getServiceProviderNameIdQualifier();
+

Review comment:
       I wonder if we could use an existing Enum or create new one to use 
instead of plain strings.

##########
File path: 
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/auth/JPASAML2SP.java
##########
@@ -192,4 +241,62 @@ public void setServiceProviderNameIdQualifier(final String 
serviceProviderNameId
         this.serviceProviderNameIdQualifier = serviceProviderNameIdQualifier;
     }
 
+    @Override
+    public List<String> getSigningSignatureAlgorithms() {
+        return signingSignatureAlgorithms;
+    }
+
+    @Override
+    public void setSigningSignatureAlgorithms(final List<String> 
signingSignatureAlgorithms) {
+        this.signingSignatureAlgorithms = signingSignatureAlgorithms;
+    }
+
+    @Override
+    public List<String> getSigningSignatureReferenceDigestMethods() {
+        return signingSignatureReferenceDigestMethods;
+    }
+
+    @Override
+    public void setSigningSignatureReferenceDigestMethods(final List<String> 
signingSignatureReferenceDigestMethods) {
+        this.signingSignatureReferenceDigestMethods = 
signingSignatureReferenceDigestMethods;
+    }
+
+    @Override
+    public List<String> getEncryptionDataAlgorithms() {
+        return encryptionDataAlgorithms;
+    }
+
+    @Override
+    public void setEncryptionDataAlgorithms(final List<String> 
encryptionDataAlgorithms) {
+        this.encryptionDataAlgorithms = encryptionDataAlgorithms;
+    }
+
+    @Override
+    public List<String> getEncryptionKeyAlgorithms() {
+        return encryptionKeyAlgorithms;
+    }
+
+    @Override
+    public void setEncryptionKeyAlgorithms(final List<String> 
encryptionKeyAlgorithms) {
+        this.encryptionKeyAlgorithms = encryptionKeyAlgorithms;
+    }
+
+    @Override
+    public List<String> getSigningSignatureBlackListedAlgorithms() {
+        return signingSignatureBlackListedAlgorithms;
+    }
+
+    @Override
+    public void setSigningSignatureBlackListedAlgorithms(final List<String> 
signingSignatureBlackListedAlgorithms) {
+        this.signingSignatureBlackListedAlgorithms = 
signingSignatureBlackListedAlgorithms;
+    }
+
+    @Override
+    public List<String> getEncryptionBlackListedAlgorithms() {
+        return encryptionBlackListedAlgorithms;
+    }
+
+    public void setEncryptionBlackListedAlgorithms(final List<String> 
encryptionBlackListedAlgorithms) {

Review comment:
       Please fix this code scanning alert.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to