mmoayyed commented on a change in pull request #221: URL: https://github.com/apache/syncope/pull/221#discussion_r508310127
########## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/auth/SAML2SP.java ########## @@ -73,4 +75,28 @@ void setServiceProviderNameIdQualifier(String location); String getServiceProviderNameIdQualifier(); + Review comment: Looks around. Can't find an existing enum, but it would be feasible to create an enum of all algorithms listed here: https://www.w3.org/TR/xmlsec-algorithms/ Apache Santuario has a component that lists everything as a String constant: https://santuario.apache.org/Java/api/org/apache/xml/security/encryption/XMLCipher.html Perhaps this can be used in the enum we'd create? This seems like it would be consistent with the approach we take elsewhere in WA. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org