DmitriyBrashevets commented on a change in pull request #264:
URL: https://github.com/apache/syncope/pull/264#discussion_r636180820
##########
File path:
core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java
##########
@@ -48,7 +49,7 @@
private static final Map<String, Class<?>> CLASS_CACHE =
Collections.synchronizedMap(new HashMap<>());
- public static Optional<Reportlet> buildReportlet(final Implementation impl)
+ public static Optional<Reportlet> buildReportlet(final String domain,
final Implementation impl)
Review comment:
I thought that it's becoming more understandable (visible) if public
methods have the additional parameter declared explicitly. But can be removed...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
