DmitriyBrashevets commented on a change in pull request #264:
URL: https://github.com/apache/syncope/pull/264#discussion_r636192432
##########
File path:
core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java
##########
@@ -48,7 +49,7 @@
private static final Map<String, Class<?>> CLASS_CACHE =
Collections.synchronizedMap(new HashMap<>());
- public static Optional<Reportlet> buildReportlet(final Implementation impl)
+ public static Optional<Reportlet> buildReportlet(final String domain,
final Implementation impl)
Review comment:
removed addtional param
##########
File path:
core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java
##########
@@ -72,7 +73,7 @@
}
}
- public static Optional<AccountRule> buildAccountRule(final Implementation
impl)
+ public static Optional<AccountRule> buildAccountRule(final String domain,
final Implementation impl)
Review comment:
removed addtional param
##########
File path:
core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java
##########
@@ -96,7 +97,7 @@
}
}
- public static Optional<PasswordRule> buildPasswordRule(final
Implementation impl)
+ public static Optional<PasswordRule> buildPasswordRule(final String
domain, final Implementation impl)
Review comment:
removed addtional param
##########
File path:
core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java
##########
@@ -120,7 +121,7 @@
}
}
- public static Optional<PullCorrelationRule> buildPullCorrelationRule(final
Implementation impl)
+ public static Optional<PullCorrelationRule> buildPullCorrelationRule(final
String domain, final Implementation impl)
Review comment:
removed addtional param
##########
File path:
core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java
##########
@@ -145,7 +146,7 @@
}
}
- public static Optional<PushCorrelationRule> buildPushCorrelationRule(final
Implementation impl)
+ public static Optional<PushCorrelationRule> buildPushCorrelationRule(final
String domain, final Implementation impl)
Review comment:
removed addtional param
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
