ilgrosso commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993326009
##########
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##########
@@ -61,8 +61,23 @@ public abstract class AbstractService implements
JAXRSService {
protected String getActualKey(final AnyDAO<?> dao, final String
pretendingKey) {
String actualKey = pretendingKey;
- if (!SyncopeConstants.UUID_PATTERN.matcher(pretendingKey).matches()) {
- actualKey = dao.findKey(pretendingKey);
+ if (uriInfo.getPathParameters(true).containsKey("key")) {
Review Comment:
what I was meaning is that if you call `getActualKey(dao, null)` the current
proposed implemenation will not even look at path parameters, but just raise
the exception `Key is null`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
