ilgrosso commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993347291
##########
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##########
@@ -61,8 +61,23 @@ public abstract class AbstractService implements
JAXRSService {
protected String getActualKey(final AnyDAO<?> dao, final String
pretendingKey) {
String actualKey = pretendingKey;
- if (!SyncopeConstants.UUID_PATTERN.matcher(pretendingKey).matches()) {
- actualKey = dao.findKey(pretendingKey);
+ if (uriInfo.getPathParameters(true).containsKey("key")) {
Review Comment:
you're right about the mismatch in my proposal; still, the current one will
not even attempt to look at path parameters if the payload key is `null`
So it seems we are attempting to pursue two objectives here:
1. avoid NPE in case the payload bears a `null` key
2. if both path parameter and payload's `key` are provided, check if they
are the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
