ilgrosso commented on code in PR #1141:
URL: https://github.com/apache/syncope/pull/1141#discussion_r2228373794
##########
wa/bootstrap/src/main/java/org/apache/syncope/wa/bootstrap/WAPropertySourceLocator.java:
##########
@@ -124,6 +127,12 @@ public PropertySource<?> locate(final Environment
environment) {
properties.putAll(index(map, prefixes));
});
+ LOG.debug("Configure properties for CAS password manager on syncope:");
Review Comment:
This would be the sole LOG of such a type in this class, please remove
##########
wa/bootstrap/src/main/java/org/apache/syncope/wa/bootstrap/mapping/PropertySourceMapper.java:
##########
@@ -37,7 +37,7 @@ public abstract class PropertySourceMapper {
protected static final Logger LOG =
LoggerFactory.getLogger(PropertySourceMapper.class);
- protected static Map<String, Object> prefix(final String prefix, final
Map<String, Object> map) {
+ public static Map<String, Object> prefix(final String prefix, final
Map<String, Object> map) {
Review Comment:
Why it is needed to change this visibility?
##########
fit/wa-reference/src/test/java/org/apache/syncope/fit/AbstractITCase.java:
##########
@@ -231,6 +231,19 @@ protected static String extractWAExecution(final String
body) {
return execution.get();
}
+ protected static String extractWACSRF(final String body) {
Review Comment:
Why placing this method in this class? If used only by `OIDCC4UIITCase` it
should stay there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
