ilgrosso commented on code in PR #1141:
URL: https://github.com/apache/syncope/pull/1141#discussion_r2228407007


##########
wa/bootstrap/src/main/java/org/apache/syncope/wa/bootstrap/WAPropertySourceLocator.java:
##########
@@ -124,6 +127,12 @@ public PropertySource<?> locate(final Environment 
environment) {
             properties.putAll(index(map, prefixes));
         });
 
+        LOG.debug("Configure properties for CAS password manager on syncope:");
+        SyncopePasswordManagementProperties pm = new 
SyncopePasswordManagementProperties();

Review Comment:
   This seems overkill, just use plain
   
   ```java
   properties.put(
   "cas.authn.pm.syncope.url", 
   StringUtils.substringBefore(syncopeClient.getAddress(), "/rest"));
   ```
   
   and you will also avoid changing the visibility of 
`PropertySourceMapper#prefix`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to