ilgrosso commented on code in PR #1379: URL: https://github.com/apache/syncope/pull/1379#discussion_r3347698910
########## client/idrepo/console/src/main/java/org/apache/syncope/client/console/chartjs/data/ChartData.java: ########## @@ -1,47 +1,50 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ -package org.apache.syncope.client.console.chartjs; - -import java.io.Serializable; -import java.util.ArrayList; -import java.util.List; - -/** - * Provides labels and datasets. - * - * @param <T> the dataset type - */ -abstract class ChartData<T extends BaseDataSet> implements Serializable { - - private static final long serialVersionUID = -5230056951310645070L; - - /** The labels. */ - private final List<String> labels = new ArrayList<>(); - - /** The datasets. */ - private final List<T> datasets = new ArrayList<>(); - - public List<String> getLabels() { - return labels; - } - - public List<T> getDatasets() { - return datasets; - } -} +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.syncope.client.console.chartjs.data; + +import com.fasterxml.jackson.annotation.JsonInclude; +import java.io.Serializable; +import java.util.ArrayList; +import java.util.List; + +@JsonInclude(JsonInclude.Include.NON_NULL) +public class ChartData<T extends Dataset> implements Serializable { + + private static final long serialVersionUID = -8489073681001237058L; + + private List<String> labels = new ArrayList<>(); + Review Comment: all the collections in these java beans shall be made `final` with no setter methods (as the rest of pojos in the Syncope code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
