github-advanced-security[bot] commented on code in PR #1379: URL: https://github.com/apache/syncope/pull/1379#discussion_r3348911973
########## client/idrepo/console/src/main/java/org/apache/syncope/client/console/chartjs/data/ChartData.java: ########## @@ -1,47 +1,42 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ -package org.apache.syncope.client.console.chartjs; - -import java.io.Serializable; -import java.util.ArrayList; -import java.util.List; - -/** - * Provides labels and datasets. - * - * @param <T> the dataset type - */ -abstract class ChartData<T extends BaseDataSet> implements Serializable { - - private static final long serialVersionUID = -5230056951310645070L; - - /** The labels. */ - private final List<String> labels = new ArrayList<>(); - - /** The datasets. */ - private final List<T> datasets = new ArrayList<>(); - - public List<String> getLabels() { - return labels; - } - - public List<T> getDatasets() { - return datasets; - } -} +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.syncope.client.console.chartjs.data; + +import com.fasterxml.jackson.annotation.JsonInclude; +import java.io.Serializable; +import java.util.ArrayList; +import java.util.List; + +@JsonInclude(JsonInclude.Include.NON_NULL) +public class ChartData<T extends Dataset> implements Serializable { + + private static final long serialVersionUID = -8489073681001237058L; + + private final List<String> labels = new ArrayList<>(); + + private final List<Dataset> datasets = new ArrayList<>(); + + public List<String> getLabels() { + return labels; + } + + public List<Dataset> getDatasets() { Review Comment: ## CodeQL / Exposing internal representation getDatasets exposes the internal representation stored in field datasets. The value may be modified [after this call to getDatasets](1). getDatasets exposes the internal representation stored in field datasets. The value may be modified [after this call to getDatasets](2). getDatasets exposes the internal representation stored in field datasets. The value may be modified [after this call to getDatasets](3). getDatasets exposes the internal representation stored in field datasets. The value may be modified [after this call to getDatasets](4). getDatasets exposes the internal representation stored in field datasets. The value may be modified [after this call to getDatasets](5). getDatasets exposes the internal representation stored in field datasets. The value may be modified [after this call to getDatasets](6). getDatasets exposes the internal representation stored in field datasets. The value may be modified [after this call to getDatasets](7). [Show more details](https://github.com/apache/syncope/security/code-scanning/2633) ########## client/idrepo/console/src/main/java/org/apache/syncope/client/console/chartjs/data/ChartData.java: ########## @@ -1,47 +1,42 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ -package org.apache.syncope.client.console.chartjs; - -import java.io.Serializable; -import java.util.ArrayList; -import java.util.List; - -/** - * Provides labels and datasets. - * - * @param <T> the dataset type - */ -abstract class ChartData<T extends BaseDataSet> implements Serializable { - - private static final long serialVersionUID = -5230056951310645070L; - - /** The labels. */ - private final List<String> labels = new ArrayList<>(); - - /** The datasets. */ - private final List<T> datasets = new ArrayList<>(); - - public List<String> getLabels() { - return labels; - } - - public List<T> getDatasets() { - return datasets; - } -} +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.syncope.client.console.chartjs.data; + +import com.fasterxml.jackson.annotation.JsonInclude; +import java.io.Serializable; +import java.util.ArrayList; +import java.util.List; + +@JsonInclude(JsonInclude.Include.NON_NULL) +public class ChartData<T extends Dataset> implements Serializable { + + private static final long serialVersionUID = -8489073681001237058L; + + private final List<String> labels = new ArrayList<>(); + + private final List<Dataset> datasets = new ArrayList<>(); + + public List<String> getLabels() { Review Comment: ## CodeQL / Exposing internal representation getLabels exposes the internal representation stored in field labels. The value may be modified [after this call to getLabels](1). getLabels exposes the internal representation stored in field labels. The value may be modified [after this call to getLabels](2). getLabels exposes the internal representation stored in field labels. The value may be modified [after this call to getLabels](3). getLabels exposes the internal representation stored in field labels. The value may be modified [after this call to getLabels](4). getLabels exposes the internal representation stored in field labels. The value may be modified [after this call to getLabels](5). [Show more details](https://github.com/apache/syncope/security/code-scanning/2634) ########## client/idrepo/console/src/main/java/org/apache/syncope/client/console/chartjs/data/Dataset.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.syncope.client.console.chartjs.data; + +import com.fasterxml.jackson.annotation.JsonInclude; +import java.io.Serializable; +import java.util.ArrayList; +import java.util.List; + +@JsonInclude(JsonInclude.Include.NON_NULL) +public abstract class Dataset implements Serializable { + + private static final long serialVersionUID = -9143409945075593686L; + + private final List<Number> data = new ArrayList<>(); + + private final List<String> label = new ArrayList<>(); + + private final List<String> backgroundColor = new ArrayList<>(); + + private final List<String> borderColor = new ArrayList<>(); + + private Boolean hidden; + + private Double tension; + + public Double getTension() { + return tension; + } + + public void setTension(final Double tension) { + this.tension = tension; + } + + public List<Number> getData() { + return data; + } + + public List<String> getLabel() { + return label; + } + + public List<String> getBackgroundColor() { Review Comment: ## CodeQL / Exposing internal representation getBackgroundColor exposes the internal representation stored in field backgroundColor. The value may be modified [after this call to getBackgroundColor](1). getBackgroundColor exposes the internal representation stored in field backgroundColor. The value may be modified [after this call to getBackgroundColor](2). getBackgroundColor exposes the internal representation stored in field backgroundColor. The value may be modified [after this call to getBackgroundColor](3). getBackgroundColor exposes the internal representation stored in field backgroundColor. The value may be modified [after this call to getBackgroundColor](4). getBackgroundColor exposes the internal representation stored in field backgroundColor. The value may be modified [after this call to getBackgroundColor](5). getBackgroundColor exposes the internal representation stored in field backgroundColor. The value may be modified [after this call to getBackgroundColor](6). [Show more details](https://github.com/apache/syncope/security/code-scanning/2636) ########## client/idrepo/console/src/main/java/org/apache/syncope/client/console/chartjs/data/Dataset.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.syncope.client.console.chartjs.data; + +import com.fasterxml.jackson.annotation.JsonInclude; +import java.io.Serializable; +import java.util.ArrayList; +import java.util.List; + +@JsonInclude(JsonInclude.Include.NON_NULL) +public abstract class Dataset implements Serializable { + + private static final long serialVersionUID = -9143409945075593686L; + + private final List<Number> data = new ArrayList<>(); + + private final List<String> label = new ArrayList<>(); + + private final List<String> backgroundColor = new ArrayList<>(); + + private final List<String> borderColor = new ArrayList<>(); + + private Boolean hidden; + + private Double tension; + + public Double getTension() { + return tension; + } + + public void setTension(final Double tension) { + this.tension = tension; + } + + public List<Number> getData() { + return data; + } + + public List<String> getLabel() { Review Comment: ## CodeQL / Exposing internal representation getLabel exposes the internal representation stored in field label. The value may be modified [after this call to getLabel](1). getLabel exposes the internal representation stored in field label. The value may be modified [after this call to getLabel](2). getLabel exposes the internal representation stored in field label. The value may be modified [after this call to getLabel](3). [Show more details](https://github.com/apache/syncope/security/code-scanning/2637) ########## client/idrepo/console/src/main/java/org/apache/syncope/client/console/chartjs/data/Dataset.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.syncope.client.console.chartjs.data; + +import com.fasterxml.jackson.annotation.JsonInclude; +import java.io.Serializable; +import java.util.ArrayList; +import java.util.List; + +@JsonInclude(JsonInclude.Include.NON_NULL) +public abstract class Dataset implements Serializable { + + private static final long serialVersionUID = -9143409945075593686L; + + private final List<Number> data = new ArrayList<>(); + + private final List<String> label = new ArrayList<>(); + + private final List<String> backgroundColor = new ArrayList<>(); + + private final List<String> borderColor = new ArrayList<>(); + + private Boolean hidden; + + private Double tension; + + public Double getTension() { + return tension; + } + + public void setTension(final Double tension) { + this.tension = tension; + } + + public List<Number> getData() { Review Comment: ## CodeQL / Exposing internal representation getData exposes the internal representation stored in field data. The value may be modified [after this call to getData](1). getData exposes the internal representation stored in field data. The value may be modified [after this call to getData](2). getData exposes the internal representation stored in field data. The value may be modified [after this call to getData](3). getData exposes the internal representation stored in field data. The value may be modified [after this call to getData](4). getData exposes the internal representation stored in field data. The value may be modified [after this call to getData](5). getData exposes the internal representation stored in field data. The value may be modified [after this call to getData](6). [Show more details](https://github.com/apache/syncope/security/code-scanning/2638) ########## client/idrepo/console/src/main/java/org/apache/syncope/client/console/chartjs/data/Dataset.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.syncope.client.console.chartjs.data; + +import com.fasterxml.jackson.annotation.JsonInclude; +import java.io.Serializable; +import java.util.ArrayList; +import java.util.List; + +@JsonInclude(JsonInclude.Include.NON_NULL) +public abstract class Dataset implements Serializable { + + private static final long serialVersionUID = -9143409945075593686L; + + private final List<Number> data = new ArrayList<>(); + + private final List<String> label = new ArrayList<>(); + + private final List<String> backgroundColor = new ArrayList<>(); + + private final List<String> borderColor = new ArrayList<>(); + + private Boolean hidden; + + private Double tension; + + public Double getTension() { + return tension; + } + + public void setTension(final Double tension) { + this.tension = tension; + } + + public List<Number> getData() { + return data; + } + + public List<String> getLabel() { + return label; + } + + public List<String> getBackgroundColor() { + return backgroundColor; + } + + public List<String> getBorderColor() { Review Comment: ## CodeQL / Exposing internal representation getBorderColor exposes the internal representation stored in field borderColor. The value may be modified [after this call to getBorderColor](1). getBorderColor exposes the internal representation stored in field borderColor. The value may be modified [after this call to getBorderColor](2). getBorderColor exposes the internal representation stored in field borderColor. The value may be modified [after this call to getBorderColor](3). getBorderColor exposes the internal representation stored in field borderColor. The value may be modified [after this call to getBorderColor](4). getBorderColor exposes the internal representation stored in field borderColor. The value may be modified [after this call to getBorderColor](5). getBorderColor exposes the internal representation stored in field borderColor. The value may be modified [after this call to getBorderColor](6). [Show more details](https://github.com/apache/syncope/security/code-scanning/2635) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
