skogler commented on pull request #987: URL: https://github.com/apache/systemds/pull/987#issuecomment-657750732
Hi, yeah sure if its needed I can add it. But then you would not get the output showing which elements are incorrect. For unit tests I would prefer getting it, but I don't know all the test cases, can't say if it would be a problem or not. On Sat, 11 Jul 2020, 22:52 Sebastian Baunsgaard, <[email protected]> wrote: > Hi @skogler <https://github.com/skogler>, > > I see that this is a valid point and something we need ! > Could it maybe make sense to compare the lengths of the HashMaps for > better performance? > Since if the number differs then the output is anyway incorrect. > > Best regards > Sebastian > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/systemds/pull/987#issuecomment-657127885>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAH4BVOZYZFJ4WPEYAJBQ6TR3DGI7ANCNFSM4OXAIB5A> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
