Baunsgaard commented on pull request #987:
URL: https://github.com/apache/systemds/pull/987#issuecomment-658120203
Hi @skogler,
Thanks for the PR! :+1: .
I ended up changing it slightly to not unnecessarily increase testing time.
the most common case is that the output is correct and the sizes are the same,
therefore the edge case where the number of values are different the test
fails, while also reporting the incorrect indexes.
The only case that does not report all the incorrect indexes is if the
actual and expected contains the same number of elements, but then the test
would fail now, since the indexes would have to be different, or the values
contained different.
```java
allKeys.addAll(expectedValues.keySet());
if(expectedValues.size() != actualValues.size())
allKeys.addAll(actualValues.keySet());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
