sebwrede commented on a change in pull request #1051:
URL: https://github.com/apache/systemds/pull/1051#discussion_r486400993
##########
File path:
src/test/java/org/apache/sysds/test/functions/privacy/BuiltinGLMTest.java
##########
@@ -228,6 +229,9 @@ public void runtestGLM(PrivacyConstraint privacyConstraint,
Class<?> expectedExc
{ 100, 10, 2, 1.0, 2, 0.0, 3.0, 0.0,
2.0, 2.5 }, // Binomial two-column.logit
{ 200, 10, 2, 1.0, 3, 0.0, 3.0, 0.0,
2.0, 2.5 }, // Binomial two-column.probit
};
- return Arrays.asList(data);
+ if ( runAll )
+ return Arrays.asList(data);
+ else
+ return Arrays.asList(new Object[][]{data[0]});
Review comment:
Yes, it is very slow. The data has now also been reduced, so it is way
faster now. If we later need the different versions of GLM to test different
use cases of the privacy constraints, then we can remove the above code and
thereby include all test cases, but for now it is not necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
