Baunsgaard commented on a change in pull request #1051:
URL: https://github.com/apache/systemds/pull/1051#discussion_r486393184
##########
File path:
src/main/java/org/apache/sysds/runtime/instructions/cp/MultiReturnBuiltinCPInstruction.java
##########
@@ -47,6 +47,10 @@ public CPOperand getOutput(int i) {
return _outputs.get(i);
}
+ public ArrayList<CPOperand> getOutputs(){
Review comment:
well, its an opinion thing, i like to return the highest abstraction, i
think we had a course this was mentioned as a point.
Software Engineering... :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]