ywcb00 opened a new pull request #1182: URL: https://github.com/apache/systemds/pull/1182
Hi, This PR includes a cleanup over the FederatedBinaryMatrixMatrixInstruction in order to support all the edge cases and also column partitioned federated input. I've extended the FederatedLogicalTest to test all the edge cases. Note: The test class includes also tests for full partitioned federated input (outcommented because we do not support it yet) but I would keep the functionality of testing full partitioned input for eventual future improvements where we add support for it. Thanks for review :) PS: There are a lot of different data configurations inside the test, most of them outcommented because of the test performance, but all of them are facing different edge cases of federated binary operations. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
