mboehm7 commented on pull request #1182: URL: https://github.com/apache/systemds/pull/1182#issuecomment-782716153
LGTM - thanks @ywcb00. I only reduce some of the redundant tests (not every configuration needs to test all comparison operators is is done elsewhere already). Furthermore, a week ago I already fixed the handling of FULL federated matrices - so it should automatically apply for either row or col branches. Maybe if you get a chance you could double check the full handling/exceptions are still needed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
