Baunsgaard commented on a change in pull request #1189: URL: https://github.com/apache/systemds/pull/1189#discussion_r585082788
########## File path: src/test/java/org/apache/sysds/test/functions/builtin/BuiltinCoxTest.java ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.sysds.test.functions.builtin; + +import org.apache.sysds.common.Types; +import org.apache.sysds.test.AutomatedTestBase; +import org.apache.sysds.test.TestConfiguration; +import org.junit.Test; + +public class BuiltinCoxTest extends AutomatedTestBase +{ + private final static String TEST_NAME = "cox"; + private final static String TEST_DIR = "functions/builtin/"; + private final static String TEST_CLASS_DIR = TEST_DIR + BuiltinCoxTest.class.getSimpleName() + "/"; + + @Override + public void setUp() { + addTestConfiguration(TEST_NAME, new TestConfiguration(TEST_CLASS_DIR, TEST_NAME,new String[]{"B"})); + } + + @Test + public void testFunction() { + runCoxTest(50, 2.0, 1.5, 0.8, 100, 0.05, 1.0,0.000001, 100, 0); + } + + public void runCoxTest(int numRecords, double scaleWeibull, double shapeWeibull, double prob, + int numFeatures, double sparsity, double alpha, double tol, int moi, int mii) { + Types.ExecMode platformOld = setExecMode(Types.ExecMode.SINGLE_NODE); + loadTestConfiguration(getTestConfiguration(TEST_NAME)); + String HOME = SCRIPT_DIR + TEST_DIR; + fullDMLScriptName = HOME + TEST_NAME + ".dml"; + + programArgs = new String[]{ + "-nvargs", "M=" + output("M"), "S=" + output("S"), "T=" + output("T"), "COV=" + output("COV"), + "RT=" + output("RT"), "XO=" + output("XO"), "n=" + numRecords, "l=" + scaleWeibull, + "v=" + shapeWeibull, "p=" + prob, "m=" + numFeatures, "sp=" + sparsity, + "alpha=" + alpha, "tol=" + tol, "moi=" + moi, "mii=" + mii}; + + runTest(true, false, null, -1); Review comment: it is a challenge to test the algorithms, if there is an equivalent algorithm in R then that would be fine to compare with. But best would be if we could test it ourselves. My suggestion is to keep it simple, and try to think of the algorithm as a black box. If you know what it does, then try to deconstruct what behavior is expected based on as simple an input as possible. and then expand from there. I don't expect you to test in all edge cases, just that we know it works on commonly expected inputs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
