Shafaq-Siddiqi commented on pull request #1189: URL: https://github.com/apache/systemds/pull/1189#issuecomment-794317442
> > Hi, > > Thank you for your contribution. The PR looks in a good shape. Just one minor task if you could please add the R scripts and compare the functions with equivalent R functions. You can have a look into other built-in i.e., winsorize, to see how we are comparing them against R functions. > > Could you help me figure it out how I should have the input in the R script? You gave me the idea to generate the input data within the test/*.dml script and so I am not really sure how I should do with the R script You need to search for the Km() and cox() functions in the R library then create a cox.R file and call the R implementation of cox() on the same dataset that you are using in cox.dml file and write the results. In the BuiltinCox.java file run the R script and read both R and DML output and compare them. Do the same for km. You can refer to winsorize.R script to see how the inputs are read and written. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
