Baunsgaard commented on a change in pull request #1406:
URL: https://github.com/apache/systemds/pull/1406#discussion_r724865889



##########
File path: src/main/java/org/apache/sysds/lops/Unary.java
##########
@@ -122,7 +122,12 @@ private String getOpcode() {
        }
        
        public static boolean isMultiThreadedOp(OpOp1 op) {
-               return op==OpOp1.CUMSUM
+               if(op == OpOp1.INVERSE || op == OpOp1.CHOLESKY || op == 
OpOp1.DETECTSCHEMA)

Review comment:
       ah okay, i get it, so you simply inverted it.
   this makes it a one liner instead.
   
   return !(op == OpOp1.INVERSE || op == OpOp1.CHOLESKY || op == 
OpOp1.DETECTSCHEMA);
   
   you can remove all the other code in the method
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to