Baunsgaard commented on a change in pull request #1406:
URL: https://github.com/apache/systemds/pull/1406#discussion_r724866734
##########
File path:
src/main/java/org/apache/sysds/runtime/instructions/cp/UnaryCPInstruction.java
##########
@@ -61,8 +63,9 @@ public static UnaryCPInstruction parseInstruction ( String
str ) {
in.split(parts[1]);
out.split(parts[2]);
func = Builtin.getBuiltinFnObject(opcode);
-
- if( Arrays.asList(new
String[]{"ucumk+","ucum*","ucumk+*","ucummin","ucummax","exp","log","sigmoid"}).contains(opcode)
){
+ Types.OpOp1 op_type =
Types.OpOp1.valueOfByOpcode(opcode);
+ //if( Arrays.asList(new
String[]{"ucumk+","ucum*","ucumk+*","ucummin","ucummax","exp","log","sigmoid","round"}).contains(opcode)
)
+ if( Unary.isMultiThreadedOp(op_type)){
Review comment:
I get it based on the last comment.
##########
File path:
src/main/java/org/apache/sysds/runtime/instructions/cp/UnaryCPInstruction.java
##########
@@ -61,8 +63,9 @@ public static UnaryCPInstruction parseInstruction ( String
str ) {
in.split(parts[1]);
out.split(parts[2]);
func = Builtin.getBuiltinFnObject(opcode);
-
- if( Arrays.asList(new
String[]{"ucumk+","ucum*","ucumk+*","ucummin","ucummax","exp","log","sigmoid"}).contains(opcode)
){
+ Types.OpOp1 op_type =
Types.OpOp1.valueOfByOpcode(opcode);
+ //if( Arrays.asList(new
String[]{"ucumk+","ucum*","ucumk+*","ucummin","ucummax","exp","log","sigmoid","round"}).contains(opcode)
)
+ if( Unary.isMultiThreadedOp(op_type)){
Review comment:
I get it based on the last comment. but remove the commented code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
