Thank you all for voting and finding the issues. I will cut another RC once all the issues are resolved.
Just a reminder, please stick to only fixes for this release and leave the good-to-have improvements for future releases. I will appreciate it if you merge the fixes in the release branch, branch-2.2.0 along with Main. Regards, Arnab.. On Fri, Nov 12, 2021 at 3:05 PM Baunsgaard, Sebastian <[email protected]> wrote: > > Hi, > > > -1 > > > There is breaking bugs in execution using release artifacts: > > > Federated reuse of workers via python (this bug is related to no clear > command being send to the federated workers). > > python startup with environment set to release. > > writing lists of matrices with empty matrices. > > Local execution of parameter server crash in edge cases. > > > then there is nice to have, but they really should be included: > > > error messages when using federated workers (should at least print on the > worker) > > > best regards > > Sebastian > > ________________________________ > From: Mark Dokter <[email protected]> > Sent: Thursday, November 11, 2021 7:19:59 PM > To: [email protected] > Subject: Re: [VOTE] Apache SystemDS 2.2.1 (RC1) > > Hi! > > TLDR: +1 > > I have tested the bin.tgz release artifact. A few non fatal glitches in > the run script may be fixed by including [1], if there is another RC. > > I checked the signature and checksums. They're all valid of course ;-) A > suggestion to improve/streamline the checksums: If you add the file name > of the file to check in the file containing the checksum (separated by a > space) you can use the check functionality of (for example) sha1sum like > so: > > $ sha1sum -c systemds-2.2.1-bin.tgz.sha1 > systemds-2.2.1-bin.tgz: OK > > That works if the content of systemds-2.2.1-bin.tgz.sha1 looks like this: > $ cat systemds-2.2.1-bin.tgz.sha1 > 78104fed26d80c108c61fff491a3265bd1b710cc systemds-2.2.1-bin.tgz > > At the moment, the checksum files only contain the checksum, not the > file name. A minor change in the release scripts could make the > <checksum><space><filename> format of the md5/sha* files happen. > > Since these suggestions are not critical I'd say +1 > > Regards, Mark > > > [1] https://github.com/apache/systemds/pull/1456 > [ > https://opengraph.githubassets.com/03f81ed3b4152b40ce4cdf115ee1f2ab132d4b7eb8a8f2272677472348e3b0bb/apache/systemds/pull/1456 > ]<https://github.com/apache/systemds/pull/1456> > > [MINOR] Run script bug fixes: by corepointer · Pull Request #1456 · > apache/systemds · GitHub<https://github.com/apache/systemds/pull/1456> > github.com > Move the setting of SYSTEMDS_ROOT before its first use Search for a config > xml file name that is actually included in the bin release > > > > On 10.11.21 16:24, arnab phani wrote: > > Please vote on releasing the following candidate as Apache SystemDS > version > > 2.2.1 > > > > The vote is open for at least 72 hours and passes if a majority of at > least > > 3 +1 PMC votes are cast. > > > > [ ] +1 Release this package as Apache SystemDS 2.2.1 > > [ ] -1 Do not release this package because ... > > > > To learn more about Apache SystemDS, please see > > > https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fsystemds.apache.org%2F&data=04%7C01%7Cmdokter%40know-center.at%7C86ba7734bff0430d812408d9a45e4a2a%7C0d3c92e977ae4f49bd126ff29e8f1c37%7C0%7C0%7C637721547745500935%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=hNxyq8JABeF1%2Fp94f3ZIOy9AWkzi%2B9ggtnC7MWrYqkc%3D&reserved=0 > Apache SystemDS - An open source ML system for the end-to-end data science > lifecycle< > https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fsystemds.apache.org%2F&data=04%7C01%7Cmdokter%40know-center.at%7C86ba7734bff0430d812408d9a45e4a2a%7C0d3c92e977ae4f49bd126ff29e8f1c37%7C0%7C0%7C637721547745500935%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=hNxyq8JABeF1%2Fp94f3ZIOy9AWkzi%2B9ggtnC7MWrYqkc%3D&reserved=0 > > > eur02.safelinks.protection.outlook.com > Apache SystemDS is an open source ML system for the end-to-end data > science lifecycle > > > > > > > > The tag to be voted on is > > 2.2.1-rc1 (3a1681555f79b03c318eadee147be6923a4164eb): > > > https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fsystemds%2Ftree%2F2.2.1-rc1&data=04%7C01%7Cmdokter%40know-center.at%7C86ba7734bff0430d812408d9a45e4a2a%7C0d3c92e977ae4f49bd126ff29e8f1c37%7C0%7C0%7C637721547745500935%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=uSKwV1Fw19Zs5NEX4x6lPpi%2FUfk4b5lnJAH2rjYYbks%3D&reserved=0 > [ > https://opengraph.githubassets.com/199f9f08cb905a4632c60ed1867db619652b3b1de4575d2fa90de04cb9f45123/apache/systemds > ]< > https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fsystemds%2Ftree%2F2.2.1-rc1&data=04%7C01%7Cmdokter%40know-center.at%7C86ba7734bff0430d812408d9a45e4a2a%7C0d3c92e977ae4f49bd126ff29e8f1c37%7C0%7C0%7C637721547745500935%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=uSKwV1Fw19Zs5NEX4x6lPpi%2FUfk4b5lnJAH2rjYYbks%3D&reserved=0 > > > > GitHub - apache/systemds at 2.2.1-rc1< > https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fsystemds%2Ftree%2F2.2.1-rc1&data=04%7C01%7Cmdokter%40know-center.at%7C86ba7734bff0430d812408d9a45e4a2a%7C0d3c92e977ae4f49bd126ff29e8f1c37%7C0%7C0%7C637721547745500935%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=uSKwV1Fw19Zs5NEX4x6lPpi%2FUfk4b5lnJAH2rjYYbks%3D&reserved=0 > > > eur02.safelinks.protection.outlook.com > An open source ML system for the end-to-end data science lifecycle - > GitHub - apache/systemds at 2.2.1-rc1 > > > > > > The release artifacts can be found at: > > > https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fsystemds%2F2.2.1-rc1%2F&data=04%7C01%7Cmdokter%40know-center.at%7C86ba7734bff0430d812408d9a45e4a2a%7C0d3c92e977ae4f49bd126ff29e8f1c37%7C0%7C0%7C637721547745500935%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=%2Fv%2BS6kzCg5TAtmu5g3YTYt1%2BcNMXxOL%2FYuB7BzEa1mI%3D&reserved=0 > > > > The maven release artifacts, including signatures, digests, etc. can be > > found at: > > > https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Forgapachesystemds-1069%2Forg%2Fapache%2Fsystemds%2Fsystemds%2F2.2.1%2F&data=04%7C01%7Cmdokter%40know-center.at%7C86ba7734bff0430d812408d9a45e4a2a%7C0d3c92e977ae4f49bd126ff29e8f1c37%7C0%7C0%7C637721547745500935%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=NVdHKuLSFqowpJfRnDePflTccfjvgEEUVWgEtXDq%2FA8%3D&reserved=0 > > > > > > > > =========================== > > == Apache Release policy == > > =========================== > > > https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.apache.org%2Flegal%2Frelease-policy.html&data=04%7C01%7Cmdokter%40know-center.at%7C86ba7734bff0430d812408d9a45e4a2a%7C0d3c92e977ae4f49bd126ff29e8f1c37%7C0%7C0%7C637721547745500935%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=JxePZwRYdp8bYw7IpLPjS91PfYWh3Lmn1wO%2Fo1K%2FDno%3D&reserved=0 > Release Policy< > https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.apache.org%2Flegal%2Frelease-policy.html&data=04%7C01%7Cmdokter%40know-center.at%7C86ba7734bff0430d812408d9a45e4a2a%7C0d3c92e977ae4f49bd126ff29e8f1c37%7C0%7C0%7C637721547745500935%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=JxePZwRYdp8bYw7IpLPjS91PfYWh3Lmn1wO%2Fo1K%2FDno%3D&reserved=0 > > > eur02.safelinks.protection.outlook.com > Home page of The Apache Software Foundation > > > > > > > > ======================================= > > == How can I help test this release? == > > ======================================= > > If you are a SystemDS user, you can help us test this release by taking > an > > existing Algorithm or workload and running on this release candidate, > then > > reporting any regressions. > > > > ================================================ > > == What justifies a -1 vote for this release? == > > ================================================ > > -1 votes should only occur for significant stop-ship bugs or legal > related > > issues (e.g. wrong license, missing header files, etc). Minor bugs or > > regressions should not block this release. > > > > Regards, > > Arnab.. > > >
