Baunsgaard commented on a change in pull request #1489:
URL: https://github.com/apache/systemds/pull/1489#discussion_r778333985
##########
File path: src/test/java/org/apache/sysds/test/TestUtils.java
##########
@@ -1802,6 +1802,16 @@ public static MatrixBlock generateTestMatrixBlock(int
rows, int cols, double min
return MatrixBlock.randOperations(rows, cols, sparsity, min,
max, "Uniform", seed);
}
+ public static MatrixBlock generateTestMatrixBlockSym(int rows, int
cols, double min, double max, double sparsity, long seed){
+ MatrixBlock m = MatrixBlock.randOperations(rows, cols,
sparsity, min, max, "Uniform", seed);
+ for(int i = 0; i < rows; i++) {
Review comment:
very unclear comment from my side, and completely wrong, it seems like i
was getting worse over time while reviewing.
My intention was to ignore the diagonal values in the matrix, since they
don't have an effect.
but the code already does this, and i was just a bit to quick in my comment.
That said you could consider changing the implementation to not call rand,
and instead generate the values yourself since the current implementation goes
through the matrix twice.
If you don't want to (this is only a test generator anyway) then leave a
TODO comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
