Baunsgaard opened a new pull request #1524:
URL: https://github.com/apache/systemds/pull/1524
Reason for change:
to avoid warning from Spark using different version and therefore warning on
every execution.
Further suggestions:
- I would like to suggest that we remove the files:
DmlLexer, DmlListener, DmlParser, and DMLBaseListener from GitHub, and
instead git ignore these.
I know the decision was previously made to keep them but the current solution
for handling them specified in our .gitignore is (in my opinion)
insufficient.
- The downside is we have to build them on first pull of systemds by
running 'mvn package' once.
- I have removed the DML.tokens and DMLLexer.tokens files since these have
changed in v 4.8 and are generated differently.
df231d6c1bffc25dc8477d7a2e3a71d59ee509f9 speficied these to be included, but i
would suggest we try to git ignore them to see if they really are needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
