mboehm7 commented on pull request #1524: URL: https://github.com/apache/systemds/pull/1524#issuecomment-1030921193
As discussed offline, please keep the generated parser in the repository to keep the setup simple for new contributors (without the need for a maven build that creates the parser). Also please verify (if you didn't do it yet) that it still runs with Spark 2.4 (which also has an ANTLR dependency - getting warnings on Spark 3 is better than no warnings on Spark 3 but errors on Spark 2.4) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
