sebwrede commented on pull request #1525: URL: https://github.com/apache/systemds/pull/1525#issuecomment-1038870956
> this current implementation means that we built in a dependency to mkl/blas and now SEAL in the same resource. I think this is why it does not work in Docker currently. SEAL would only work if we use mkl/blas as well and this is not something we do in the Docker tests at the moment. > Preferably i think it would be better if we separate these two dependencies such that: > > 1. We make a new header file for the SEAL dependency and build into new different .so /.dll filles for SEAL bindings in src/main/cpp/lib, perhaps called libsystemds_seal-Linux-x86_64.so and libsystemds_seal-Windows-AMD64.so. > > 2. We make a new Java file that binds to it (instead of extending src/main/java/org/apache/sysds/utils/NativeHelper.java) I think suggestion 1 is a good idea, but suggestion 2 depends on how we define the purpose of NativeHelper. Currently, it is the only interface to the libraries, which means that we will always know where to look for the native calls. I see that until now the native helper has only been used for the mkl/blas calls, but I don't know if this has been a design decision or a coincidence since it was the only libraries added in the beginning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
